Fix quantiles #331
Closed
Fix quantiles #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns of numpy; fix assertion (0 and 1 are valid quantiles)
|
Now a bunch of tests are failing on MacOS (Linux timed out). Failing tests are due to bad fits, not being able to read analysis results etc. I suspect it's because we're running pyyaml 5.1 on the travis CI build, which has caused problems in the past: threeML/astromodels#97 |
|
This looks good to merge. I am not fond of the removal of the input checking, but numpy is likely to take care of that for us. Lets see! |
|
I'm not sure if this is needed anymore. Is anyone still using numpy 1.12? I think we can close this (and the related issue 329. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incompatibility issue with old versions of numpy as discussed here: #289