Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uniqueness: don't use a private Rails API #995

Merged
merged 1 commit into from Jul 11, 2020
Merged

uniqueness: don't use a private Rails API #995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/shoulda/matchers/active_record/validate_uniqueness_of_matcher.rb
View file
Open in desktop
Expand Up @@ -396,7 +396,7 @@ def description_for_case_sensitive_qualifier
end

def validations
model._validators[@attribute].select do |validator|
model.validators_on(@attribute).select do |validator|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, https://apidock.com/rails/ActiveModel/Validations/ClassMethods/validators_on does seem more appropriate.

validator.is_a?(::ActiveRecord::Validations::UniquenessValidator)
end
end
Expand Down