Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inline documentation about is_greater_than in validate_comparison_of matcher #1616

Conversation

jeduardo824
Copy link
Contributor

This PR fixes the initial example the inline documentation of the validate_comparison_of matcher. In the example, the matcher is using greater_than(...) in the tests, but it is actually is_greater_than(...).

@vsppedro
Copy link
Collaborator

vsppedro commented Feb 25, 2024

Hey, @jeduardo824, great find!

I noticed another one at

# should validate_comparison_of(:number_of_dependents).greater_than(0).on(:create)

Could you include this in your pull request too?

Thanks a lot for your contribution!

@jeduardo824 jeduardo824 force-pushed the fix-inline-documentation-of-validates-comparison-matcher branch from 22c25d6 to 7ae5718 Compare February 26, 2024 13:14
@jeduardo824
Copy link
Contributor Author

Hey, @jeduardo824, great find!

I noticed another one at

# should validate_comparison_of(:number_of_dependents).greater_than(0).on(:create)

Could you include this in your pull request too?

Thanks a lot for your contribution!

Job done!

@vsppedro
Copy link
Collaborator

Thank you!

@vsppedro vsppedro merged commit 6488e3a into thoughtbot:main Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants