Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: false positive of validate_presence_of #1545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: false positive of validate_presence_of #1545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/shoulda/matchers/active_model/validate_presence_of_matcher.rb
View file
Open in desktop
Expand Up @@ -245,7 +245,8 @@ def allows_and_double_checks_value_of!(value)
end

def allows_original_or_typecast_value?(value)
allows_value_of(value, @expected_message)
@expected_message == :blank ? allows_value_of(value, nil) : allows_value_of(value, @expected_message)
# allows_value_of(value, @expected_message)
end

def disallows_and_double_checks_value_of!(value)
Expand Down