Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle argument delegation for Ruby 3 #1406

Merged

Conversation

gaetanm
Copy link
Contributor

@gaetanm gaetanm commented Jan 28, 2021

Hi,

I'm trying to get rid of all the warnings I have when I launch Rspec on my project. Like this one:

ruby/gems/2.7.0/gems/shoulda-matchers-4.5.1/lib/shoulda/matchers/rails_shim.rb:68: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

That double splat does fix it.

@VSPPedro
Copy link
Collaborator

VSPPedro commented Feb 5, 2021

Thank you very much for your contribution!

@VSPPedro VSPPedro merged commit e1d622c into thoughtbot:master Feb 5, 2021
@VSPPedro VSPPedro mentioned this pull request Jun 4, 2021
@VSPPedro VSPPedro mentioned this pull request Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants