Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix have_db_column.with_options misspelled options #1358

Merged
merged 1 commit into from Dec 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/shoulda/matchers/active_record/have_db_column_matcher.rb
Expand Up @@ -84,6 +84,8 @@ def have_db_column(column)

# @private
class HaveDbColumnMatcher
OPTIONS = %i(precision limit default null scale primary)

def initialize(column)
@column = column
@options = {}
Expand All @@ -95,7 +97,8 @@ def of_type(column_type)
end

def with_options(opts = {})
%w(precision limit default null scale primary).each do |attribute|
validate_options(opts)
OPTIONS.each do |attribute|
if opts.key?(attribute.to_sym)
@options[attribute.to_sym] = opts[attribute.to_sym]
end
Expand Down Expand Up @@ -137,6 +140,13 @@ def description

protected

def validate_options(opts)
invalid_options = opts.keys.map(&:to_sym) - OPTIONS
if invalid_options.any?
raise ArgumentError, "Unknown option(s): #{invalid_options.map(&:inspect).join(", ")}"
end
end

def column_exists?
if model_class.column_names.include?(@column.to_s)
true
Expand Down
Expand Up @@ -98,6 +98,14 @@
end
end

context 'with invalid argument option' do
it 'raises an error with the unknown options' do
expect {
have_db_column(:salary).with_options(preccision: 5, primaryy: true)
}.to raise_error("Unknown option(s): :preccision, :primaryy")
end
end

def model(options = {})
define_model(:employee, options).new
end
Expand Down