Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep consistency on allow_blank and allow_nil qualifiers #1123

Merged
merged 1 commit into from
Sep 1, 2018
Merged

Keep consistency on allow_blank and allow_nil qualifiers #1123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 4 additions & 5 deletions lib/shoulda/matchers/active_model/validate_inclusion_of_matcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,18 +310,17 @@ def in_range(range)
self
end

def allow_blank(allow_blank = true)
@options[:allow_blank] = allow_blank
def allow_blank
@options[:allow_blank] = true
self
end

def expects_to_allow_blank?
@options[:allow_blank]
end

def allow_nil(allow_nil = true)
@options[:allow_nil] = allow_nil
self
def allow_nil
@options[:allow_nil] = true
end

def expects_to_allow_nil?
Expand Down