Truncate long values in descriptions. Fixes #1041

thoughtbot · May 6, 2020 · 8bf411f · 8bf411f
1 parent 390c2ca
commit 8bf411f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/shoulda/matchers/util.rb b/lib/shoulda/matchers/util.rb
@@ -4,6 +4,8 @@ module Shoulda
   module Matchers
     # @private
     module Util
+      MAXIMUM_LENGTH_OF_VALUE_TO_DISPLAY = 500
+
       def self.deconstantize(path)
         if defined?(ActiveSupport::Inflector) &&
           ActiveSupport::Inflector.respond_to?(:deconstantize)
@@ -47,7 +49,12 @@ def self.inspect_value(value)
         when Range
           inspect_range(value)
         else
-          "‹#{value.inspect}›"
+          inspected_value = value.inspect
+          if inspected_value.length > MAXIMUM_LENGTH_OF_VALUE_TO_DISPLAY
+            "‹#{inspected_value[0, MAXIMUM_LENGTH_OF_VALUE_TO_DISPLAY]}...›"
+          else
+            "‹#{inspected_value}›"
+          end
         end
       end
 

diff --git a/spec/unit/shoulda/matchers/active_model/allow_value_matcher_spec.rb b/spec/unit/shoulda/matchers/active_model/allow_value_matcher_spec.rb
@@ -41,6 +41,12 @@
         )
       end
     end
+
+    it 'truncates the description when long' do
+      matcher = allow_value("A" * 10000).for(:baz)
+
+      expect(matcher.description).to eq "allow :baz to be ‹\"#{"A" * 499}...›"
+    end
   end
 
   describe '#_after_setting_value' do