Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match supported Ruby versions with shoulda-matchers #73

Closed
wants to merge 1 commit into from

Conversation

TastyPi
Copy link

@TastyPi TastyPi commented Jan 27, 2023

I want to make sure the tests I'll be writing for #71 pass on appropriate Ruby versions.

I got the list from here https://github.com/thoughtbot/shoulda-matchers/blob/8fc832d52c36ac24d2c2d283c8d3665106f0e90f/.github/workflows/ci.yml#L29

@vsppedro
Copy link
Collaborator

vsppedro commented Feb 12, 2023

Hi, @TastyPi, thank you for your PR!

Sorry for taking so long to respond. To be honest, I'm having a hard time accepting that the CI got green with no changes on the Appraisals file. Rails 4.2 not failing with Ruby 3.2? I wonder if the tests have even started.

I think it would be better to start using Github Actions keeping the same ruby version that we have in the project at the moment and in others PRs we could start adding or dropping until we make identical to the file in the shoulda-matchsers project. What do you think? Would you like to make one of these contributions?

@TastyPi
Copy link
Author

TastyPi commented Feb 13, 2023

Makes sense to me. Are you also asking if I would implement GitHub Actions or will you take that on?

@TastyPi TastyPi closed this Feb 13, 2023
@TastyPi TastyPi deleted the patch-2 branch February 13, 2023 16:16
@vsppedro
Copy link
Collaborator

Sorry, I expressed myself badly. I was asking if you were interested in converting this contribution of yours to another one, which could be adding github actions to this project. If you don't want to do that, that's fine. I'll work on that ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants