Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Replace mimemagic with marcel gem #2684

Conversation

pjmartorell
Copy link

@pjmartorell pjmartorell commented Mar 26, 2021

Replace mimemagic with marcel gem.
Resolves #2678

require 'logger'
require 'marcel'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dismiss the suggestion for consistency with the rest of single quoted requires

@pjmartorell
Copy link
Author

@mike-burns or any other maintainer, I think this issue should be addressed in order to circumvent the issue with mimemagic not being compliant with the GPL license.

@mike-burns
Copy link
Contributor

But mimemagic is MIT licensed. Do we need to do a thing here?

@pjmartorell
Copy link
Author

pjmartorell commented Mar 26, 2021

yes, but they circumvented the issue with GPL downloading the problematic GPL file at runtime instead of including it in the source code, which is not an option for environments were the communication with the outside world is restricted.

@mike-burns
Copy link
Contributor

Those environments will need to install the shared-mime-info package. They already need to install other packages (ImageMagick, Ruby, etc.), so I'm not terribly concerned.

Since this isn't a license violation for Paperclip, and since Paperclip is deprecated, I'm going to close this. Thank you for bringing it up.

@mike-burns mike-burns closed this Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paperclip mimemagic dependency licensing implication
2 participants