Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

@WIP Fixed bug where processing occurs on invalid objects #2594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Aug 19, 2018

  1. @wip Fixed bug where processing occurs on invalid objects

    - Because the processors were called on assignment, instead of during saving,
      the validations could never work correctly. This is because the built in
      validations use the values in the db columns to operate. However, since these
      are populated on assignment, the validations cannot run before the processors
      run. Moreover, any other type of validation not dependent on the db columns
      also cannot run, because the processors are called on assignment. The
      processors should be called during save which allows for validations to occur.
    
    - Fixed tests that assert the incorrect behavior
    
    - Closes thoughtbot#2462, Closes thoughtbot#2321, Closes
      thoughtbot#2236, Closes thoughtbot#2178,
      Closes thoughtbot#1960, Closes thoughtbot#2204
    saghaulor committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    eaed2af View commit details
    Browse the repository at this point in the history