Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Remove bad exception handling! #2476

Merged
merged 2 commits into from Oct 25, 2017
Merged

Remove bad exception handling! #2476

merged 2 commits into from Oct 25, 2017

Commits on Aug 2, 2017

  1. Remove bad exception handling! 

    Exception is the root of Ruby's exception hierarchy, so when you rescue Exception you rescue from everything, including subclasses such as SyntaxError, LoadError, and Interrupt etc which is a bad idea.

Fix: rescue from StandardError.
    @gaurish
    gaurish committed Aug 2, 2017
    Copy the full SHA
    9b80206 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2017

  1. Be more explicit

    @gaurish
    gaurish committed Oct 25, 2017
    Copy the full SHA
    cbbb5c2 View commit details
    Browse the repository at this point in the history