This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Ignore invalid Content-Disposition header #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,8 +29,8 @@ def content_type_from_content | |||
|
|
|||
| def filename_from_content_disposition | |||
| if @content.meta.has_key?("content-disposition") | |||
| @content.meta["content-disposition"]. | |||
| match(/filename="([^"]*)"/)[1] | |||
| matches = @content.meta["content-disposition"].match(/filename="([^"]*)"/) | |||
|
There is no behavior change now. Does this fix #2283? |
|
Yes, the exception is now gone |
|
Thank you! |
|
Is it possible we are almost ready to cut a new release with this regression fix? |
|
Is there a chance this could be backported to 4.3? |
|
As an aside, a Content-Disposition is allowed to not contain a filename component. So strictly speaking this fix is not only for "invalid Content-Disposition", making it even more useful. I backup @maletor, it would be great to have a new release with this fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is one way to fix #2283