This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Use Sass.load_paths instead of SASS_PATH env #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgalarza
force-pushed
the
dg-sass-load-paths
branch
from
0ab07be
to
c3e5ac2
Compare
The SASS_PATH environment variable is not intended to be set by another library but rather by consumers of Sass. Since the environment variable is only read in once at the first time `load_paths` is called. This was causing an error where, if a user had another gem such as `bootstrap-sass` and it was being loaded before `neat` was, the modifications to `SASS_PATH` we were making were never read in, so the neat files would never be found. See https://github.com/sass/sass/blob/1b628f03b9361fa6047097c9fd0d01b21247b8f3/lib/sass.rb#L20-L43
dgalarza
force-pushed
the
dg-sass-load-paths
branch
from
c950dcd
to
d6bc594
Compare
tysongach
approved these changes
Jun 26, 2017
|
Oh, looks like #595 has this fixed, as well. Closing in favor of that since it was already open. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#The SASS_PATH environment variable is not intended to be set by another
library but rather by consumers of Sass. Since the environment variable
is only read in once at the first time
load_pathsis called.This was causing an error where, if a user had another gem such as
bootstrap-sassand it was being loaded beforeneatwas, themodifications to
SASS_PATHwe were making were never read in, so theneat files would never be found.
See https://github.com/sass/sass/blob/1b628f03b9361fa6047097c9fd0d01b21247b8f3/lib/sass.rb#L20-L43