Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a failing test for reloading with Spring #330

Merged
merged 2 commits into from Apr 5, 2019
Merged

Write a failing test for reloading with Spring #330

merged 2 commits into from Apr 5, 2019

Commits on Apr 5, 2019

  1. Write a failing test for reloading with Spring 

    This test captures what I think is going on in
#323

Currently the factory_bot_rails reloader only reloads factory
definitions when the definition files have changes (using
`execute_if_updated`).

This can cause problems when editing an application file without also
editing a factory_bot definition file. Rails will reload the entire
application, but will not reload the definitions. This causes
factory_bot to have references to classes that were unloaded from the
Rails application and replaced with new classes.

#329 replaces
`execute_if_updated` with `execute` so that factory_bot_rails will
reload the definition files whenever anything in the application is
changed. Hopefully that PR will get this test to pass!
    @composerinteralia
    composerinteralia committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    122ccb3 View commit details
    Browse the repository at this point in the history

  2. fixup! Write a failing test for reloading with Spring

    @composerinteralia
    composerinteralia committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    dacd980 View commit details
    Browse the repository at this point in the history