Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add exist paths to reloading target #317

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/factory_bot_rails/definition_file_paths.rb
Expand Up @@ -2,8 +2,6 @@

module FactoryBotRails
class DefinitionFilePaths
attr_reader :files, :directories

def initialize(definition_file_paths)
@files = []
@directories = {}
Expand All @@ -13,5 +11,13 @@ def initialize(definition_file_paths)
@directories[path.to_s] = [:rb]
end
end

def directories
@directories.select { |path| Dir.exist?(path) }
end

def files
@files.select { |file| File.exist?(file) }
end
end
end
17 changes: 8 additions & 9 deletions spec/factory_bot_rails/definition_file_paths_spec.rb
Expand Up @@ -2,33 +2,32 @@

describe FactoryBotRails::DefinitionFilePaths do
describe "#files" do
it "returns a list of definition files" do
definition_file_paths = ["definition_path", "another_definition_path"]
it "returns a list of definition files that only exist" do
definition_file_paths = ["spec/fixtures/factories", "not_exist_directory"]

files = described_class.new(definition_file_paths).files

expect(files).to eq ["definition_path.rb", "another_definition_path.rb"]
expect(files).to eq ["spec/fixtures/factories.rb"]
end
end

describe "#directories" do
it "returns a hash of definition directories" do
definition_file_paths = ["definition_path", "another_definition_path"]
it "returns a hash of definition directories that only exist" do
definition_file_paths = ["spec/fixtures/factories", "not_exist_directory"]

directories = described_class.new(definition_file_paths).directories

expect(directories).to eq(
"definition_path" => [:rb],
"another_definition_path" => [:rb],
"spec/fixtures/factories" => [:rb],
)
end

it "converts Pathname objects to strings" do
definition_file_paths = [Pathname.new("definition_path")]
definition_file_paths = [Pathname.new("spec/fixtures/factories")]

directories = described_class.new(definition_file_paths).directories

expect(directories).to eq("definition_path" => [:rb])
expect(directories).to eq("spec/fixtures/factories" => [:rb])
end
end
end