Write a failing test for reloading with Spring #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composerinteralia
force-pushed
the
reloading-test
branch
from
cbcfd1e
to
d9eb7d5
Compare
This test captures what I think is going on in #323 Currently the factory_bot_rails reloader only reloads factory definitions when the definition files have changes (using `execute_if_updated`). This can cause problems when editing an application file without also editing a factory_bot definition file. Rails will reload the entire application, but will not reload the definitions. This causes factory_bot to have references to classes that were unloaded from the Rails application and replaced with new classes. #329 replaces `execute_if_updated` with `execute` so that factory_bot_rails will reload the definition files whenever anything in the application is changed. Hopefully that PR will get this test to pass!
composerinteralia
force-pushed
the
reloading-test
branch
from
d9eb7d5
to
122ccb3
Compare
|
Chatted IRL: the build was failing for the wrong reasons on previous versions of rails ( |
|
Oh no! Now all the tests are passing. That was not supposed to happen. |
|
Seems right, and the CI failures all seem correct. It seems to pass on Rails 6 -- so this is fixed there, too? |
|
I was actually surprised to see the Rails 6 tests passing, but I assume it is because of the new Zietwerk loader |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test captures what I think is going on in
#323
Currently the factory_bot_rails reloader only reloads factory
definitions when the definition files have changes (using
execute_if_updated).This can cause problems when editing an application file without also
editing a factory_bot definition file. Rails will reload the entire
application, but will not reload the definitions. This causes
factory_bot to have references to classes that were unloaded from the
Rails application and replaced with new classes.
#329 replaces
execute_if_updatedwithexecuteso that factory_bot_rails willreload the definition files whenever anything in the application is
changed. Hopefully that PR will get this test to pass!