Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump standard from 1.18.0 to 1.34.0 #1624

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

ydah
Copy link
Contributor

@ydah ydah commented Feb 19, 2024

This PR bump standard from 1.18.0 to 1.34.0.

```
standard: Use Ruby Standard Style (https://github.com/standardrb/standard)
  Rakefile:34:34: Style/RedundantParentheses: Don't use parentheses around a logical expression.
  lib/factory_bot/attribute_assigner.rb:16:32: Performance/StringIdentifierArgument: Use `:"#{attribute}="` instead of `"#{attribute}="`.
standard: Run `standardrb --fix` to fix up to 2 problems.
```
@mike-burns
Copy link
Contributor

mike-burns commented Feb 19, 2024

Changelog.

This gets the new LSP feature, Rubocop 1.60, the fix for combining stdin with parallel, and DisabledByDefault (all of Rubocop is disabled, and we opt in), among others.

@mike-burns mike-burns merged commit 053ef4a into thoughtbot:main Feb 19, 2024
19 checks passed
@ydah ydah deleted the bump_standard branch February 19, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants