-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rough draft of Namespaced Factories #1453
base: master
Are you sure you want to change the base?
Rough draft of Namespaced Factories #1453
Commits on Nov 24, 2020
-
Rough draft of Namespaced Factories
See: thoughtbot#199 I have a number of clients who use FactoryBot and are working through the difficult challene of decomposing a large monolith into either domain-driven namespaces; or small gems/engines that are "plugged into" a larger monolith. In most cases, we've been able to get away with keeping the factories bundled with their extracted modules and using distinct names. However there's also been a bit of copy-pasting of factory code back into the monolith in cases where the names really _do_ need to be shared. This is an attempt to bring @joshuaclayton's example of namespacing into the core FactoryBot DSL. If you'd prefer I packaged this as it's own gem, I'd be happy to do so; but I'd be stoked to see this in the core FactoryBot package!
Configuration menu - View commit details
-
Copy full SHA for 49c9a61 - Browse repository at this point
Copy the full SHA 49c9a61View commit details
Commits on Jan 14, 2022
-
Add Ruby 3.1 and Rails 7 to CI (thoughtbot#1526)
This PR adds the Ruby 3.1 and Rails 7 elements to the CI matrix. To support those changes a number of other changes were required: - Adding a basic Rails 7 Gemfile and updating `Appraisals` - Quoting 3.0 in the `.github/workflows/build.yml` file so that this entry pulls Ruby 3.0.x and not Ruby 3.1 - Adding the "--disable-error_highlight" value for RUBYOPT in the build environment to disable Ruby 3.1 error highlighting - Bumping the version of `standard` and configuring it to run against our oldest supported version
Configuration menu - View commit details
-
Copy full SHA for b7eb4db - Browse repository at this point
Copy the full SHA b7eb4dbView commit details -
Update GETTING_STARTED: include note about saving in
create_list
(t……houghtbot#1522) Fixes thoughtbot#1444 and thoughtbot#1479 Add a short note in GETTING_STARTED.md about the need to save the record after it has been modified
Configuration menu - View commit details
-
Copy full SHA for fc098ff - Browse repository at this point
Copy the full SHA fc098ffView commit details
Commits on Mar 8, 2022
-
Apply standard formatting to address errors in specs
What? ===== This applies standard's formatting fixes across the codebase.
Configuration menu - View commit details
-
Copy full SHA for 6244b5d - Browse repository at this point
Copy the full SHA 6244b5dView commit details -
Adjust GitHub Actions so linting occurs separately from test suite
What? ===== This adjusts the GitHub Actions setup so running `standard` occurs separately from running the specs via Appraisal.
Configuration menu - View commit details
-
Copy full SHA for 8f766ef - Browse repository at this point
Copy the full SHA 8f766efView commit details -
Fix strategy tracking through associations
What? ===== Within FactoryBot::Evaluator, the build strategy was reported either as a class OR symbol. A side-effect of this is misreporting within ActiveSupport::Notifications hooks, since the instrumentation payload may have strategies listed as e.g. `:create` or `FactoryBot::Strategy::Create`, even though they semantically represent the same information. This introduces a new instance method for all strategies, `to_sym`, to be called rather than `class`.
Configuration menu - View commit details
-
Copy full SHA for 1b81d5d - Browse repository at this point
Copy the full SHA 1b81d5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc65e78 - Browse repository at this point
Copy the full SHA dc65e78View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8b9dbc - Browse repository at this point
Copy the full SHA e8b9dbcView commit details
Commits on Apr 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fc9bb59 - Browse repository at this point
Copy the full SHA fc9bb59View commit details
Commits on Jun 8, 2022
-
Fix some typo (thoughtbot#1542)
* Fix typo "delcaration" -> "declaration" * Fix typo "Ususually" -> "Usually" * Fix typo "assocition" -> "association" * Fix typo "vaue" -> "value"
Configuration menu - View commit details
-
Copy full SHA for 09053ea - Browse repository at this point
Copy the full SHA 09053eaView commit details
Commits on Jun 28, 2022
-
Updated README (thoughtbot#1543)
Fixed CI link. Updated Copyright year
Configuration menu - View commit details
-
Copy full SHA for e49e728 - Browse repository at this point
Copy the full SHA e49e728View commit details
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ec71611 - Browse repository at this point
Copy the full SHA ec71611View commit details
Commits on Oct 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4c3bc65 - Browse repository at this point
Copy the full SHA 4c3bc65View commit details