Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make git_source work in nested groups #160

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Make git_source work in nested groups #160

merged 1 commit into from
Feb 10, 2020

Commits on Feb 10, 2020

  1. Make git_source work in nested groups 

    If you declare a `git_source` at the top level of your Gemfile or a spec in
Appraisals, it will substitute the gem source in `gem` declarations. If you
want to use those gem sources in nested groups declared with `group`,
`platforms`, `platform`, `source`, `git`, or `path`, the `git_source`
declarations from the top level aren't inherited, so they don't work like they
do with bundler.

Fortunately, in `BundlerDSL` there's a protected `git_sources` writer, and all
the groups are also declared in that file. It should be easy enough to assign
all of the group objects to a copy of the `git_sources`. That would make the
substitutions work.

Fixes thoughtbot#159.
    @BrianHawley @nickcharlton
    BrianHawley authored and nickcharlton committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    a88ea24 View commit details
    Browse the repository at this point in the history