Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid line continuations without parentheses. #138

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Avoid line continuations without parentheses. #138

merged 1 commit into from
Mar 13, 2018

Commits on Mar 13, 2018

  1. Avoid line continuations without parentheses. 

    This causes unexpected behaviour: The `not_to` spec will always pass,
whilst the `to include` specs don't test for the presence of the command
line, rather nothing. This is because Ruby treats the `include` as having no
argument and the string below as a string literal.

If we wrap in parentheses, the positive spec fails as the path is
relative to the root partition.

The solution here is to provide a full path when comparing
`gemfile='...'`. This also fixes a broken expectation where `not_to` and
`to` were flipped.
    @nickcharlton
    nickcharlton committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    f18fee1 View commit details
    Browse the repository at this point in the history