Call dynamic-readme reusable workflow #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened a PR to fix the CVE here: #2551 |
|
I fixed the CVE in #2540 (sorry, I didn't see your PR until too late!). This looks fine to me, other than a comment which applies here too that I made on |
stefannibrasil
force-pushed
the
sb-dynamic-readme-workflow
branch
from
272c144
to
863357c
Compare
|
branch rebased and comment addressed 👍 |
We want to have a way to edit our README footer at one place and have the changes from there be propagated to our repos. By adding this snippet in the README, we call this reusable workflow: https://github.com/thoughtbot/templates/blob/main/.github/workflows/dynamic-readme.yaml that renders the README footer dynamically.
nickcharlton
force-pushed
the
sb-dynamic-readme-workflow
branch
from
9bb1cfe
to
15b881f
Compare
|
Thanks for keeping this going! The test failures are #2523, so I'm ignoring them for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to have a way to edit our README footer at one place and have the changes from there be propagated to our repos.
By adding this snippet in the README, we call this reusable workflow: https://github.com/thoughtbot/templates/blob/main/.github/workflows/dynamic-readme.yaml that renders the README footer dynamically.
This workflow has been updated to accommodate repositories that have main branch rules. To generate the README dynamically, you’ll need to merge a PR with the README changes. That will trigger the GitHub workflow.
The PR won’t be generated if the footer does not have any differences. It will only be open if there’s an update to the footer snippet.