Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Views::IndexGenerator to copy all partials #2452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goosys
Copy link

@goosys goosys commented Nov 1, 2023

I believe this is an oversight from when the templates were split in a previous version.
Please review.

@nickcharlton
Copy link
Member

I'm not sure if we do actually want to do this — are you finding you do override stuff like pagination, or the headers? The code here hasn't changed much in years.

One other option would be to add a new generator for overriding the specifics, or we could also just do nothing and let users figure it out!

@goosys
Copy link
Author

goosys commented Dec 20, 2023

@nickcharlton
Thank you for the review.

These templates are not generated by any generator. Shouldn't we enable them to be generated by the generator as a guide for users who want to customize the templates?

One other option would be to add a new generator for overriding the specifics

I'm prepared to create a new generator and submit a pull request. In that case, what do you think would be an appropriate name for the generator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants