Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RichText field type #2411

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Add RichText field type #2411

wants to merge 45 commits into from

Conversation

littleforest
Copy link
Contributor

@littleforest littleforest commented Aug 4, 2023

This adds a RichText field type, completing the work started in #1660.

Screenshot 2024-03-22 at 2 14 15 PM Screenshot 2024-03-22 at 2 47 59 PM

@littleforest
Copy link
Contributor Author

Will look into the failing tests, some of them are not failing for me locally :(

@pablobm
Copy link
Collaborator

pablobm commented Aug 25, 2023

I had a look. It appears to be order-dependent.

Specifically, when I run en example from spec/generators/routes_generator_spec.rb first, followed by spec/administrate/views/fields/rich_text/_form_spec.rb, the latter fails. Looking into it a bit more, I have narrowed it down to the reset_routes call in the after hook, and in turn to the Rails.application.routes.clear! within it:

def reset_routes
Rails.application.routes.clear!
load "spec/example_app/config/routes.rb"
end

So it looks that, whatever happens there, it deletes the rails_direct_upload_url helper, making the example fail.

Thoughts?

@santosh-1987
Copy link

Are we planning to release this anytime soon - Need this badly for actiontext

@nickcharlton
Copy link
Member

@littleforest, are you able to pick up from @seanpdoyle's comments here?

(If not, I can do so!)

@littleforest
Copy link
Contributor Author

@nickcharlton I will see if I can find time to work on this second week of January. Might go faster if I can find time to pair with you or @seanpdoyle .

spec/example_app/db/schema.rb Outdated Show resolved Hide resolved
spec/example_app/db/schema.rb Outdated Show resolved Hide resolved
spec/example_app/db/schema.rb Outdated Show resolved Hide resolved
spec/example_app/db/schema.rb Outdated Show resolved Hide resolved
spec/example_app/db/schema.rb Outdated Show resolved Hide resolved
@nickcharlton
Copy link
Member

@littleforest, sorry, only getting back to this one now. How did you get on? Feel free to drop some time on my calendar if you've like to pair on this.

@seanpdoyle
Copy link
Contributor

@littleforest the asset changes merged as part of #2397 have introduced merge conflicts.

If you're interested, I'm willing to give resolving those conflicts a try and force-pushing to this branch.

If not, and you'd rather handle that yourself, that's great too!

@littleforest
Copy link
Contributor Author

I'm willing to give resolving those conflicts a try and force-pushing to this branch

That would be amazing! Thank you.

@littleforest littleforest marked this pull request as ready for review March 22, 2024 21:59
@littleforest
Copy link
Contributor Author

@seanpdoyle @nickcharlton @pablobm this is ready for re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants