Update has_many show pages #2374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure to use root collection template
|
Are you able to add a test for this? I feel like even if it's not a perfect solution, but we've got a test around the regression then it'll do for now and we can revisit it in future if necessary! |
jubilee2
force-pushed
the
fix-has_many_template
branch
4 times, most recently
from
ff12008
to
84e37c9
Compare
jubilee2
force-pushed
the
fix-has_many_template
branch
from
84e37c9
to
aab7a40
Compare
|
After adding rspec, I realized that the original solution did not work. I started to think about a different way to fix the issue. We might need another namespace for the collection template of has_many fields. |
jubilee2
force-pushed
the
fix-has_many_template
branch
from
a75ed29
to
7f72cfb
Compare
jubilee2
force-pushed
the
fix-has_many_template
branch
from
7f72cfb
to
0f02833
Compare
|
Thank you @jubilee2! I have been looking into this and now I think that is a rather complex problem 🤯 I have published a more detailed study in the issue page (see #2370 (comment)). I think the PR should close for now and discussions should happen in the issue page, until we have a better idea of how we want to tackle this. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to fix #2370, but I am not confident this it is a perfect solution.