Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fetching special files in the documentation #1698

Merged
merged 28 commits into from
Jul 31, 2020
Merged

Allow fetching special files in the documentation #1698

merged 28 commits into from
Jul 31, 2020

Commits on Jul 2, 2020

  1. Removed symlink, needs work to make contributing link work in windows… 

    … friendly manner
    @EWright212
    EWright212 committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    a242a5a View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Hardcoded contributing link

    @EWright212
    EWright212 committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    8f8431c View commit details
    Browse the repository at this point in the history

  2. Removing hardcoding for special files 

    Co-Authored by: Kehinde Olofinmoyin <kehindeolofinmoyin@hotmail.com>
    @EWright212
    EWright212 committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    d3419ef View commit details
    Browse the repository at this point in the history

  3. Removed all hardcoding for special files in case of future additions … 

    …- requires refactoring
    @EWright212
    EWright212 committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    6f71bb2 View commit details
    Browse the repository at this point in the history

  4. Minor refactor 

    Co-Authored by: Kehinde P. Olofinmoyin <kehindeolofinmoyin@hotmail.com>
    @EWright212
    EWright212 committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    d9ca5d5 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Refactor

    @EWright212
    EWright212 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    39da36d View commit details
    Browse the repository at this point in the history

  2. Refactor houndbot lint warnings

    @EWright212
    EWright212 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    23ca18a View commit details
    Browse the repository at this point in the history

  3. Refactor lint houndbot warnings

    @EWright212
    EWright212 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6a25b06 View commit details
    Browse the repository at this point in the history

  4. Refactor lint houndbot warnings again

    @EWright212
    EWright212 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    52b315d View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Update to ruby naming convention

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    c40b697 View commit details
    Browse the repository at this point in the history

  2. Change all instances of check special file to find special file

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    e587791 View commit details
    Browse the repository at this point in the history

  3. find special file returns only one item instead of array

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    dc2d271 View commit details
    Browse the repository at this point in the history

  4. Remove p

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    f548edd View commit details
    Browse the repository at this point in the history

  5. Refactor fix houndbot warnings

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    5a8cd6d View commit details
    Browse the repository at this point in the history

  6. Logic in show method moved to private method

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    a5f58a8 View commit details
    Browse the repository at this point in the history

  7. Remove index method from docs controller but hardcoded

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    1ed0804 View commit details
    Browse the repository at this point in the history

  8. index page included in finding special files

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    6102412 View commit details
    Browse the repository at this point in the history

  9. Refactor and remove ps

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b2ebae7 View commit details
    Browse the repository at this point in the history

  10. Update for Nick's comments - Refactor

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    7b1ea40 View commit details
    Browse the repository at this point in the history

  11. Refactor - houndbot warnings

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    824fa19 View commit details
    Browse the repository at this point in the history

  12. Refactor - houndbot warnings

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0e8ba21 View commit details
    Browse the repository at this point in the history

  13. if statement to ternary

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    6337815 View commit details
    Browse the repository at this point in the history

  14. separated content returned on finding special files 

    Co-authored by: Kehinde Olofinmoyin <kehindeolofinmoyin@hotmail.com>
    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    27564b0 View commit details
    Browse the repository at this point in the history

  15. Refactor - make methods private

    @EWright212
    EWright212 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    2e7179a View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Revert "Remove index method from docs controller but hardcoded" 

    This reverts commit 1ed0804.

Removed commits that make README a special file, as they belong in their own pull request.

Fixed issue where symlink doesn't work on Windows machines. Removed symlink, instead load the Contributing.md doc via a Special File hash in the Docs Controller Class.

Co-author: Kehinde Olofinmoyin <kehindeolofinmoyin@hotmail.com>"
    @EWright212
    EWright212 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    3ae7eac View commit details
    Browse the repository at this point in the history

  2. Refactor - move find_special_file method to private

    @EWright212
    EWright212 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    57e92a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Update spec/example_app/app/controllers/docs_controller.rb 

    Co-authored-by: Nick Charlton <nick@nickcharlton.net>
    @EWright212 @nickcharlton
    EWright212 and nickcharlton committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    fcc1acd View commit details
    Browse the repository at this point in the history

  2. Update spec/example_app/app/controllers/docs_controller.rb 

    Co-authored-by: Nick Charlton <nick@nickcharlton.net>
    @EWright212 @nickcharlton
    EWright212 and nickcharlton committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    60fefb1 View commit details
    Browse the repository at this point in the history