Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't read attribute from associative field collection #1571

Closed
wants to merge 1 commit into from

Conversation

sedubois
Copy link
Contributor

@sedubois sedubois commented Mar 14, 2020

Proposal to fix #1570:

  • makes administrate-field-nested_has_many tests green again
  • fixes the NestedHasMany regressions observed in my app

@pablobm
Copy link
Collaborator

pablobm commented Mar 24, 2020

Thank you @sedubois. Sorry for the wait; I'm currently looking into this. At the moment, I'm not convinced that the issue is with Administrate, but rather with administrate-field-nested_has_many.

@pablobm
Copy link
Collaborator

pablobm commented Mar 26, 2020

OK, so my current opinion is that this should be solved at administrate-field-nested_has_many, and this is a such fix: nickcharlton/administrate-field-nested_has_many#34

Closing now!

@pablobm pablobm closed this Mar 26, 2020
@nickcharlton nickcharlton added bug breakages in functionality that is implemented fields new fields, displaying and editing data labels Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug breakages in functionality that is implemented fields new fields, displaying and editing data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.13.0 regressions with nested forms (and polymorphic relations?)
3 participants