Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align label and data on show page #1522

Merged
merged 3 commits into from Jan 25, 2020
Merged

Align label and data on show page #1522

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0acb0de
Align label and data on show page
davi-tapajos-codeminer42 Jan 10, 2020
15c2030
Take out element tag from CSS class selector
davi-tapajos-codeminer42 Jan 10, 2020
9f76b5c
Label and text alignment on show page
davi-tapajos-codeminer42 Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/stylesheets/administrate/components/_attributes.scss
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
clear: left;
float: left;
margin-bottom: $base-spacing;
margin-top: 0;
margin-top: $top-space;
text-align: right;
width: calc(15% - 1rem);
}
Expand Down
2 changes: 2 additions & 0 deletions app/assets/stylesheets/administrate/components/_cells.scss
View file
Open in desktop
@@ -1,4 +1,6 @@
.cell-label {
padding-top: $top-space;

pablobm marked this conversation as resolved.
Show resolved Hide resolved
&:hover {
a {
color: $action-color;
Expand Down
1 change: 1 addition & 0 deletions app/assets/stylesheets/administrate/library/_variables.scss
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@ $heading-line-height: 1.2 !default;
$base-border-radius: 4px !default;
$base-spacing: $base-line-height * 1em !default;
$small-spacing: $base-spacing / 2 !default;
$top-space: 0.39em !default;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that top-space it a bit generic a name. Should this be something else? I guess it'll depend on whether cell-label needs to be altered (see my comment above).


// Colors
$white: #fff !default;
Expand Down