Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-click to select attribute text #1484

Merged
merged 2 commits into from Dec 18, 2019
Merged

Double-click to select attribute text #1484

merged 2 commits into from Dec 18, 2019

Commits on Dec 9, 2019

  1. Be able to double-click to select attribute text

    Each show page displays a description list of the fields.
    When the field is text, it is rendered inside an inline `<span>`.
    
    I've found it common to want to double-click this text
    to copy-paste an identifier from our admin app into other systems.
    
    Previously, double-clicking would not select the field's value.
    The bug can be seen on the show page in the demo app. For example,
    try selecting the city or zip code values from:
    
    https://administrate-prototype.herokuapp.com/admin/orders/198962
    
    Changing the markup to be a block `<div>` fixes the bug.
    Alternatively, we could change the `preserve-whitespace` CSS rule
    to be `display: block;`.
    croaky committed Dec 9, 2019
    Copy the full SHA
    61fa60d View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Copy the full SHA
    9377623 View commit details
    Browse the repository at this point in the history