Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flakey spec: Search admin search with a filter with arguments #2523

Open
nickcharlton opened this issue Feb 16, 2024 · 1 comment · May be fixed by #2539
Open

Flakey spec: Search admin search with a filter with arguments #2523

nickcharlton opened this issue Feb 16, 2024 · 1 comment · May be fixed by #2539
Labels
bug breakages in functionality that is implemented railsconf2024 Issues worked on during RailsConf 2024 Hack Day

Comments

@nickcharlton
Copy link
Member

Flakey, but consistently flakey since we merged in #2448.

Failures:

  1) Search admin searches with a filter with arguments
     Failure/Error: expect(page).not_to have_content(standard_match.email)
       expected not to find text "me@kind.com" in "Back to app\nCustomers\nLog Entries\nOrders\nPages\nProducts\nProduct Meta Tags\nPayments\nSeries\nBlog Posts\nBlog Tags\nStats\nCustomers\nYou are logged in as Admin.\nNew customer\nEmail Email Subscriber Lifetime Value Name Orders Log Entries Kind Territory Password\nvip@kind.com - $0.00 Customer 157 0 orders 0 log entries vip Country 201 Edit\nBecome\nme@kind.com - $0.00 Customer 158 0 orders 0 log entries standard Country 202 Edit\nBecome\nstandard@kind.com - $0.00 Customer 159 0 orders 0 log entries vip Country 203 Edit\nBecome"
     # ./spec/features/search_spec.rb:105:in `block (2 levels) in <top (required)>'
     # /Users/nickcharlton/.gem/ruby/3.2.2/gems/webmock-3.20.0/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'

Finished in 14.98 seconds (files took 2.49 seconds to load)
579 examples, 1 failure

Failed examples:

rspec ./spec/features/search_spec.rb:88 # Search admin searches with a filter with arguments

Randomized with seed 33089
@nickcharlton nickcharlton added the bug breakages in functionality that is implemented label Feb 16, 2024
nickcharlton added a commit that referenced this issue Mar 1, 2024
Since we merged in #2448, this has been repeatedly failing on CI. It
doesn't fail locally, which makes it hard to debug.

Fixes #2523
nickcharlton added a commit that referenced this issue Mar 1, 2024
Since we merged in #2448, this has been repeatedly failing on CI. It
doesn't fail locally, which makes it hard to debug.

Fixes #2523
@mike-burns
Copy link
Member

https://stackoverflow.com/questions/11980109/cucumber-capybara-check-that-a-page-does-not-have-content#comment134688856_35640662

I wonder (also don't have time to work on this right now), what if we swapped lines 106 and 105. Would that cause Capybara to wait correctly?

@stefannibrasil stefannibrasil added the railsconf2024 Issues worked on during RailsConf 2024 Hack Day label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug breakages in functionality that is implemented railsconf2024 Issues worked on during RailsConf 2024 Hack Day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants