Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
protected
visibility is discouraged (#1687)
Coming from other languages, it's tempting to use `protected` in Ruby. However this keyword has different nuanced in Ruby and is generally discouraged. It should only be used for methods required for comparators and operators. None of the methods marked as `protected` here fall into this category, so I think they should be marked `private` instead.
- Loading branch information
Showing
4 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters