_navigation.html.erb: Hide resources without index (#1524)

thoughtbot · Jan 18, 2020 · 1ca811c · 1ca811c
1 parent 32ce01c
commit 1ca811c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/app/views/administrate/application/_navigation.html.erb b/app/views/administrate/application/_navigation.html.erb
@@ -15,6 +15,6 @@ as defined by the routes in the `admin/` namespace
       display_resource_name(resource),
       [namespace, resource_index_route_key(resource)],
       class: "navigation__link navigation__link--#{nav_link_state(resource)}"
-    ) %>
+    ) if valid_action? :index, resource  %>
   <% end %>
 </nav>
diff --git a/spec/example_app/config/routes.rb b/spec/example_app/config/routes.rb
@@ -5,7 +5,7 @@
     resources :log_entries
     resources :orders
     resources :products
-    resources :product_meta_tags
+    resources :product_meta_tags, except: [:index]
     resources :payments, only: [:index, :show]
     resources :series
 

diff --git a/spec/features/navigation_spec.rb b/spec/features/navigation_spec.rb
@@ -36,4 +36,10 @@
       expect(page).to have_header("Users")
     end
   end
+
+  it "hides link to resources without index page" do
+    visit admin_customers_path
+    navigation = find(".navigation")
+    expect(navigation).not_to have_link("Product Meta Tags")
+  end
 end