Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry lock version 2 #253

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Poetry lock version 2 #253

merged 4 commits into from
Jan 10, 2023

Conversation

frenzymadness
Copy link
Collaborator

Related Issues and Dependencies

#252

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Compatibility with Poetry lock file format version 2.0.

@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 4, 2023
@frenzymadness frenzymadness marked this pull request as draft January 4, 2023 17:46
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2023
@frenzymadness frenzymadness marked this pull request as ready for review January 5, 2023 10:12
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2023
@frenzymadness frenzymadness mentioned this pull request Jan 5, 2023
Closed
@frenzymadness
Copy link
Collaborator Author

Ready for review now.

@VannTen
Copy link
Member

VannTen commented Jan 9, 2023

/approve

This looks fine to me.
One nitpick : maybe .pre-commit stuff should go in another PR. They aren't really related to that feature, right ?

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@goern goern requested review from VannTen and removed request for goern January 9, 2023 11:27
fridex
fridex approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, very nice. thank you!

@sesheta
Copy link
Member

sesheta commented Jan 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frenzymadness frenzymadness merged commit fe8c6fd into thoth-station:master Jan 10, 2023
@frenzymadness frenzymadness deleted the poetry_lock_version_2 branch January 10, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridex fridex fridex approved these changes

@harshad16 harshad16 Awaiting requested review from harshad16 harshad16 is a code owner

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@VannTen VannTen Awaiting requested review from VannTen

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frenzymadness @VannTen @sesheta @fridex