New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for labels and existing PR check #57
Added support for labels and existing PR check #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting a PR!
I am happy to merge these features, I think they make sense to have. Esp. idempotency is a nice one.
Note: i'm not sure how to easily do integration testing for these features so no testing performed yet
You can do that pretty easily by opening a PR on your own fork and allowing actions there. The checks here are going to fail due to permissions issues but if I see them green on your PR, I am happy to merge things.
However, there are other build failures (formatting I believe) that need to be taken care of!
src/index.ts
Outdated
reviewers, | ||
}); | ||
} | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to do nested try
s? I think there should be a way of having only a single one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
src/index.ts
Outdated
setOutput('html_url', htmlUrl); | ||
setOutput('number', pullNumber.toString()); | ||
setOutput('html_url', htmlUrl); | ||
setOutput('pr_created', 'true'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name this one just created
? We are in the context of a PR here anyway so the naming doesn't need to repeat that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
0e878a9
to
6c18c0a
Compare
Hi, build checks on my PR got green https://github.com/vitalyal/create-pull-request/pull/1/checks |
6c18c0a
to
c3c4df2
Compare
Thank you! |
Hi @thomaseizinger , i had to fix new integration tests a bit and now the only failing test case is about reviewers because they are not configured as contributors in my fork https://github.com/vitalyal/create-pull-request/actions/runs/1055169889. |
Yeah that failing test is fine :) |
Can you also update the changelog? It is missing an |
So actually, I realized this entire action might be pointless given the existence of the |
Ok, i've moved Ureleased section to top from the bottom of the file and assume link in that section will show more changes as long as they are merged to master. |
And here is PR from main to main #61 |
Sorry, there was a misunderstanding there. The If you check the rendered output, this allows the heading to be clickable: https://github.com/thomaseizinger/create-pull-request/blob/master/CHANGELOG.md
I am going to close this as a result. |
Hello,
Thanks for publishing your action. We want to use it in our flow and faced a need to add another step next to it not to fail in case PR already exists.
So here is a PR not to fail and report via output if PR was created or not. Also support for labels is added.
Note: i'm not sure how to easily do integration testing for these features so no testing performed yet