Updated actions script for most recent puppeteer/node versions

thomasdondorf · Mar 17, 2024 · e4bfd62 · e4bfd62
1 parent a567e09
commit e4bfd62
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml
@@ -23,14 +23,13 @@ jobs:
     strategy:
       matrix:
         node:
-          - 16
-          - 14
-          - 12
-          - 10
+          - 20
+          - 18 # Support for <= 16 was dropped in puppeteer version 22.0.0
         puppeteer_version:
-          - 13.1.0 # 2022-01-17 - Chromium 98.0.4758.0
+          - 22.5.0 # 2024-03-15 - Breaking context change
+          # - 13.1.0 # 2022-01-17 - Chromium 98.0.4758.0
           # - 10.0.0 # 2021-05-31 - Chromium 92.0.4512.0
-          - 9.1.1  # (2021-02-04) - Types: PuppeteerNodeLaunchOptions introduced
+          # - 9.1.1  # (2021-02-04) - Types: PuppeteerNodeLaunchOptions introduced
           # - 7.0.1  # (2021-02-04) - First version to ship TypeScript as part of package
           # - 5.5.0 #  2020-07-02 - Chromium 88.0.4298.0
           # - 1.6.2 #  2018-08-01 - Chromium 69.0.3494.0
@@ -43,11 +42,11 @@ jobs:
       - uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node }}
-      - name: npm ci
+      - name: CI Install
         uses: bahmutov/npm-install@v1 # basically npm ci with a cache
-      - run: npm install puppeteer@${{ matrix.puppeteer_version }}
+      - run: yarn add puppeteer@${{ matrix.puppeteer_version }}
       # - run: npm test
-      - run: npm run coverage
+      - run: yarn run coverage
       - name: Collect coverage
         uses: coverallsapp/github-action@1.1.3
         with:
@@ -73,11 +72,11 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: 16
+          node-version: 20
           registry-url: https://registry.npmjs.org/
-      - name: npm ci
+      - name: CI Install
         uses: bahmutov/npm-install@v1
-      - run: npm run build
-      - run: npm publish
+      - run: yarn run build
+      - run: yarn publish
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_GITHUB_TOKEN }}