Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ci linter improvements #34

Merged
merged 4 commits into from May 31, 2022
Merged

Conversation

andypwarren
Copy link
Contributor

This PR adds some linter improvements, amongst other things:

  • fixes a bug with the default log level value
  • upgrades to the latest configkit
  • updates the linter config to remove deprecated linters, adds settings for funlen, cyclop and gci and removes funlen checking in test files. The import ordering is now Standard, Default (3rd party), Local.
  • uses the golangci-lint docker image in gitlab and exposes the version as a variable
  • updates the default Go version to v1.17.10

@andypwarren andypwarren self-assigned this May 30, 2022
{{cookiecutter.name}}/.golangci.yml Outdated Show resolved Hide resolved
{{cookiecutter.name}}/.golangci.yml Show resolved Hide resolved
Removes deprecated linters; disables gci as autofix is not supported yet; adds linter settings for funlen and cyclop; fixes issues in tests.
@andypwarren andypwarren force-pushed the feature/ci-linter-improvements branch from a30dedd to 687a924 Compare May 31, 2022 09:27
@jamesjwarren jamesjwarren merged commit 7fc8cf2 into master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants