Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PublishCorrelated Request/Outgoing event to associate a Publish… #1

Closed
wants to merge 1 commit into from

Conversation

mneumann
Copy link

… message with an external id

This simplifies associating a published message with the pkgid that it
got assigned, without having to resort to event ordering.

… message with an external id

This simplifies associating a published message with the pkgid that it
got assigned, without having to resort to event ordering.
@mneumann
Copy link
Author

Same as bytebeamio#291. Not sure if they will accept that PR. Our mqtt_client depends on this functionaliy.

@mneumann
Copy link
Author

@rina23q Can you create a separate branch from that? I would not like to merge that into the main branch. For as long as upstream rumqtt does not accept our changes, it's better to depend on a rumqtt fork maintained by thin-edge organization (and not a repo maintained by myself!).

@mneumann
Copy link
Author

@makr11st @didier-wenzek please review if you have time. this is just the functionality we need for our mqtt_client library.

Copy link

@makr11st makr11st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but I'm still struggling to see where do we need it in our client?

@mneumann
Copy link
Author

@makr11st https://github.com/thin-edge/thin-edge.io/blob/main/common/mqtt_client/src/lib.rs#L189
If we can get rid of publish_with_ack, we can get rid of this!

@makr11st
Copy link

@makr11st https://github.com/thin-edge/thin-edge.io/blob/main/common/mqtt_client/src/lib.rs#L189
If we can get rid of publish_with_ack, we can get rid of this!

It is only used in an example, no where else:
common/mqtt_client/examples/publish_test.rs

Do we really need this feature?

@mneumann mneumann closed this by deleting the head repository Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants