Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code that handles favicon.ico specifically. #20

Closed
ananthb opened this issue May 7, 2018 · 2 comments
Closed

Code that handles favicon.ico specifically. #20

ananthb opened this issue May 7, 2018 · 2 comments

Comments

@ananthb
Copy link

ananthb commented May 7, 2018

This particular behaviour should be documented so as to not catch the user by surprise. I did not add a favicon to my project and I certainly did not expect to see one when I hadn't explicitly added it.

I am also in favour of doing away with the code entirely. The benefits far out weight any potential shortcomings.

I would love to hear from the code author, rollup-plugin-serve contributors & users, and any other interested party on what exactly serving up a default favicon.ico brings to the table.

@thgh
Copy link
Owner

thgh commented Sep 6, 2018

Sounds good to me!

thgh added a commit that referenced this issue Jan 11, 2019
@thgh thgh closed this as completed in 120861a Jan 11, 2019
@ananthb
Copy link
Author

ananthb commented Jan 11, 2019

I was using my own patched version but I can get back on master now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants