Remove built-in favicon.ico

Fixes #20
thgh · Jan 11, 2019 · 0f2bcd1 · 0f2bcd1
1 parent 7e966cb
commit 0f2bcd1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/dist/favicon.ico b/dist/favicon.ico
diff --git a/src/index.js b/src/index.js
@@ -36,22 +36,11 @@ export default function serve (options = { contentBase: '' }) {
         response.writeHead(500)
         response.end('500 Internal Server Error' +
           '\n\n' + filePath +
-          '\n\n' + Object.keys(error).map(function (k) {
-            return error[k]
-          }).join('\n') +
+          '\n\n' + Object.values(error).join('\n') +
           '\n\n(rollup-plugin-serve)', 'utf-8')
         return
       }
-      if (request.url === '/favicon.ico') {
-        filePath = resolve(__dirname, '../dist/favicon.ico')
-        readFile(filePath, function (error, content) {
-          if (error) {
-            notFound(response, filePath)
-          } else {
-            found(response, filePath, content)
-          }
-        })
-      } else if (options.historyApiFallback) {
+      if (options.historyApiFallback) {
         var fallbackPath = typeof options.historyApiFallback === 'string' ? options.historyApiFallback : '/index.html'
         readFileFromContentBase(options.contentBase, fallbackPath, function (error, content, filePath) {
           if (error) {