Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use correct list type for QSliderSlots (fix: #17060) #1

Closed
wants to merge 1 commit into from

Conversation

thexeos
Copy link
Owner

@thexeos thexeos commented Mar 30, 2024

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

This fixes quasarframework#17060

Copy link

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/QRange.json b/./pr-build/api/QRange.json
index 210237a..0e30f91 100644
--- a/./current-build/api/QRange.json
+++ b/./pr-build/api/QRange.json
@@ -558,7 +558,7 @@
         },
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
@@ -657,7 +657,7 @@
       "scope": {
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
diff --git a/./current-build/api/QSlider.json b/./pr-build/api/QSlider.json
index 789c12e..ed7257f 100644
--- a/./current-build/api/QSlider.json
+++ b/./pr-build/api/QSlider.json
@@ -453,7 +453,7 @@
         },
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {
@@ -552,7 +552,7 @@
       "scope": {
         "markerList": {
           "type": "Array",
-          "tsType": "SliderMarkerLabelArrayConfig",
+          "tsType": "SliderMarkerLabelConfig",
           "desc": "Array of marker label configs",
           "definition": {
             "index": {

Types

📜 Changes detected:

diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index 2d75bf5..544dd92 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -8156,7 +8156,7 @@ export interface QRangeSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -8180,7 +8180,7 @@ export interface QRangeSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -9816,7 +9816,7 @@ export interface QSliderSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -9840,7 +9840,7 @@ export interface QSliderSlots {
     /**
      * Array of marker label configs
      */
-    markerList: SliderMarkerLabelArrayConfig[];
+    markerList: SliderMarkerLabelConfig[];
     /**
      * Object with key-value where key is the model and the value is the marker label config
      */
@@ -14502,7 +14502,6 @@ import { QInputNativeElement } from "./api";
 import { QPopupProxyInnerComponent } from "./api";
 import { SliderMarkerLabels } from "./api";
 import { SliderMarkerLabelConfig } from "./api";
-import { SliderMarkerLabelArrayConfig } from "./api";
 import { SliderMarkerLabelObjectConfig } from "./api";
 import { QTreeNode } from "./api";
 import { QUploaderFactoryFn } from "./api";

@thexeos thexeos closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant