Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: disable pip caching temporarily #1821

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

jku
Copy link
Member

@jku jku commented Feb 4, 2022

This is a temporary workaround until Github fixes either setup-python or the Windows image... If we merge this, let's file an issue to revert the workaround later.


setup-python fails on Windows currently
(actions/runner-images#5009)
Disable caching to workaround the failure.

Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com

setup-python fails on Windows currently
(actions/runner-images#5009)
Disable caching to workaround the failure.

Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1793731100

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0008%) to 97.694%

Totals Coverage Status
Change from base Build 1789410290: 0.0008%
Covered Lines: 4090
Relevant Lines: 4171

💛 - Coveralls

@jku jku marked this pull request as ready for review February 4, 2022 07:42
@MVrachev
Copy link
Collaborator

MVrachev commented Feb 4, 2022

This is a temporary workaround until Github fixes either setup-python or the Windows image... If we merge this, let's file an issue to revert the workaround later.

setup-python fails on Windows currently (actions/virtual-environments#5009) Disable caching to workaround the failure.

Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com

I saw your conversation on the issue about the pip cache, but I am not sure I understand.
How does that fix the problem? Can you elaborate more on this?

@jku
Copy link
Member Author

jku commented Feb 4, 2022

How does that fix the problem? Can you elaborate more on this?

It does not fix anything but makes setup-python not try something (caching) that currently fails on the Windows image: I don't know what that is but it might be trying to create a cache directory without enough permissions or something like that.

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick troubleshooting and filing a bug upstream, @jku! I'll merge here so that we have a working CI. Let's re-enable with #1822.

@lukpueh lukpueh merged commit 67e2b24 into theupdateframework:develop Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants