Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.20.0 #1723

Closed
wants to merge 1 commit into from
Closed

Conversation

lukpueh
Copy link
Member

@lukpueh lukpueh commented Dec 13, 2021

NOTE: This will be the final release of python-tuf that includes the legacy implementation code. Please see the 1.0.0 announcement page for more details about the next release and the deprecation of the legacy implementation, including migration instructions.

Added

Changed

Removed

This will be the final release of python-tuf that includes the
legacy implementation code. Please see the [*1.0.0
announcement*](1.0.0-ANNOUNCEMENT.md) page for more details about
the next release and the deprecation of the legacy implementation,
including migration instructions.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1572875550

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.577%

Totals Coverage Status
Change from base Build 1563115608: 0.0%
Covered Lines: 4092
Relevant Lines: 4177

💛 - Coveralls

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

Comment on lines +7 to +8
legacy implementation code. Please see the [*1.0.0
announcement*](1.0.0-ANNOUNCEMENT.md) page for more details about the next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that was a mistake but the 1.0.0 announcement ended up in root dir so this link does not work. Do we move the announcement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Thanks for catching this!

@jku
Copy link
Member

jku commented Dec 15, 2021

I've got an updated branch in https://github.com/jku/python-tuf/tree/release-0.20.0 but

  • I'd like to stop saying ngclient is not ready for prod: I've updated README in the branch
  • but if I do that, then I don't want to break ngclient API even in a minor way after that unless I really have to...
  • which means we should maybe handle the argument name change before 0.20: ngclient: Rename constructor arg #1731?

@lukpueh
Copy link
Member Author

lukpueh commented Dec 15, 2021

I've got an updated branch in https://github.com/jku/python-tuf/tree/release-0.20.0 but

  • I'd like to stop saying ngclient is not ready for prod: I've updated README in the branch

Cool, thanks! Do you want to merge the README change with this PR, or create a separate one? Also, while changing the README, would you mind adding the cncf python-tuf slack channel to the contact section? I'm pointing migration help seekers to that section in the 1.0.0-ANNOUNCEMENT doc, and I think the slack channel would be a good way to reach out to us.

  • but if I do that, then I don't want to break ngclient API even in a minor way after that unless I really have to...

I am not so concerned about minor breaking changes prior to 1.0.0. But yeah, ...

... the rename can easily land with 0.20 (just merged).

@jku
Copy link
Member

jku commented Dec 15, 2021

I can make a new PR, thanks

@jku jku mentioned this pull request Dec 15, 2021
@jku
Copy link
Member

jku commented Dec 15, 2021

I'll close this as superseded by #1732 (but feel free to redo if needed @lukpueh i'm just hopefully helping out)

@jku jku closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants