fix: out of scope error when "dest" variable is undefined #413 #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scope in the error handling portion of rewrite.
theskumar
changed the title
|
Thanks, @theGOTOguy, for the fix! |
bbc2
pushed a commit
to theGOTOguy/python-dotenv
that referenced
this pull request
Nov 11, 2022
Fixes theskumar#413 whereby the NamedTemporaryFile "dest" was out of scope in the error handling portion of rewrite. The problem was initially fixed in theskumar#414 but it got reverted because of a linter error. This new commit works around that linter error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just changed the with block to
dest = ...sincedelete=Falsewas preventing it from being cleaned up anyway, and then set a default value fordestin case an error happens earlier.