Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --override/--no-override flag to cli command run #303

Closed
wants to merge 0 commits into from
Closed

Add --override/--no-override flag to cli command run #303

wants to merge 0 commits into from

Conversation

zueve
Copy link
Contributor

@zueve zueve commented Jan 28, 2021 •
edited by bbc2

Closes #302.

@zueve zueve mentioned this pull request Jan 28, 2021
Closed
@zueve
Copy link
Contributor Author

zueve commented Jan 28, 2021

issue: #302

@coveralls
Copy link

coveralls commented Jan 28, 2021 •
edited

Coverage Status

Coverage increased (+0.02%) to 88.333% when pulling 7c4188b on zueve:master into ac670cf on theskumar:master.

@bbc2 bbc2 changed the title Add --replace flag to cli command run Add --override/--no-override flag to cli command run Feb 21, 2021
@bbc2
Copy link
Collaborator

bbc2 commented Feb 21, 2021

Thank you for your PR. I've updated it to make the flag name more consistent with the library existing parameters (replace -> override) and add tests. If this looks good to you I can merge it right away.

@bbc2 bbc2 closed this Mar 27, 2021
@bbc2
Copy link
Collaborator

bbc2 commented Mar 27, 2021

My bad I accidentally closed this. I've created #312 to replace this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --replace flag to run command
3 participants
@zueve @coveralls @bbc2