Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 261 #262

Closed
wants to merge 0 commits into from
Closed

fix issue 261 #262

wants to merge 0 commits into from

Conversation

gongqingkui
Copy link

@gongqingkui gongqingkui commented Jul 4, 2020

fix issue 261

X;\venv\lib\site-packages\dotenv\parser.py", line 44, in("string", typing.Text),
AttributeError: module 'typing' has no attribute 'Text'

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.806% when pulling 264c51f on gongqingkui:master into e4bbb8a on theskumar:master.

@bbc2
Copy link
Collaborator

bbc2 commented Jul 16, 2020

Sorry I pushed the wrong commit to your branch and that closed this pull request, preventing me from fixing your branch. I opened a new pull request (#267) where I replaced the except Exception by except (ImportError, AttributeError) because I think that's better (otherwise, it could hide unrelated problems). You can let me know what you think.

@gongqingkui
Copy link
Author

Yeah,it's a good way to resolve this question.I didn't writed it although I have thinking of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants