fix mypy

theskumar · Feb 20, 2024 · fb6e310 · fb6e310
1 parent 252462e
commit fb6e310
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/dotenv/main.py b/src/dotenv/main.py
@@ -127,6 +127,8 @@ def from_dict(self, data: Dict[str, Optional[str]], override: bool = False) -> N
                         )
                     continue
 
+                if not self._dict:
+                    self._dict = OrderedDict()
                 self._dict[key] = value
 
     def dumps(self) -> str:
@@ -143,8 +145,10 @@ def dump(self) -> None:
         """
         Write the instance to the .env file.
         """
-        with open(self.dotenv_path, "w", encoding=self.encoding) as f:
-            f.write(self.dumps())
+
+        if self.dotenv_path and os.path.isfile(self.dotenv_path):
+            with open(self.dotenv_path, "w", encoding=self.encoding) as f:
+                f.write(self.dumps())
 
 
 def get_key(

diff --git a/tests/test_main.py b/tests/test_main.py
@@ -3,6 +3,7 @@
 import os
 import sys
 import textwrap
+from typing import Dict, Optional
 from unittest import mock
 
 import pytest
@@ -402,7 +403,7 @@ def test_dotenv_values_file_stream(dotenv_path):
 
 
 def test_from_dict_and_dumps(dotenv_path):
-    data = {"a": "b", "c": "d"}
+    data: Dict[str, Optional[str]] = {"a": "b", "c": "d"}
 
     de = dotenv.main.DotEnv(dotenv_path)
     de.from_dict(data)