Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Basic] Task 6 Passing Parameters to Class Constructors #21

Merged
merged 18 commits into from
Dec 6, 2022
Merged

Conversation

Sonal3274
Copy link
Contributor

@Sonal3274 Sonal3274 commented Nov 23, 2022

Description

This adds a basic task to illustrate how to pass parameters to a class via the class constructor.

Review checklist

  • PR is split into meaningful commits for the ease of reviewing
  • Tests have been written
  • Potential solution has been added
  • Appropriate labels have been applied

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #21 (91af92c) into main (3f5e4a2) will not change coverage.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files           5        6    +1     
  Lines           8       11    +3     
=======================================
+ Hits            8       11    +3     

Copy link
Contributor

@hopeman15 hopeman15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start 🙌 Let's clean up the presentation a bit by adding a proper title and description.

We also need to add the Basic06 and Basic06Test as well.

Copy link
Contributor

@hopeman15 hopeman15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slowly getting there. Let's add a proper title, something like:

[Basic] Task 6 Passing Parameters to Class Constructors

Then let's add a proper description, something like:

This adds a basic task to illustrate how to pass parameters to a class via the class constructor.

We still need a Basic06Test, this should be as easy as copy and pasting the Basic06SolutionTest content to the newly defined test class.

@Sonal3274 Sonal3274 changed the title Basics06 solution and test [Basic] Task 6 Passing Parameters to Class Constructors Dec 5, 2022
Copy link
Contributor

@hopeman15 hopeman15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to add Basics06Test

Copy link
Contributor

@hopeman15 hopeman15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing to fix before merging.

@Sonal3274 Sonal3274 merged commit d79cc73 into main Dec 6, 2022
@Sonal3274 Sonal3274 deleted the Basics06 branch December 6, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants