Test against PHP 7.3+ and Symfony 4.0+ #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Dec 15, 2018
|
Thanks a ton, I think you've made a lot of folks quite happy :) |
|
Re: support, I'm also evaluating dropping support for older versions of PHP for a bunch of the packages soon so will probably make another pass for Symfony compat as well. Would also like to drop Symfony 2.8 support as well since it's in security fix only mode but not sure yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add new test cases to CI, this will cover new versions of PHP and Symfony. As a bonus there is a fix for Symfony deprecation in 4.2, fixed same way as in doctrine/DoctrineBundle#853.
BTW Symfony 3.3 is not supported anymore, maybe it is time to drop support for it?