Use fragment for error response on implicit grant #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please can you provide some information about why you want to add this change? Thank you |
|
I added description I hope it is clear enough. |
|
Just merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 6749 on error response of the implicit grant, the authorization server should add parameters to the fragment component of the redirection URI.
It's already done for access token response on this line, But not for error response. this PR fixes this issue.
PS: This PR also adds
$queryDelimiterproperty toOAuthServerExceptionclass to be used ongenerateHttpResponse()function. The reason behind this is we know if we should use fragment or not when initiating/throwing the exception but not when generating response.