Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added adjectival and demonym to structure #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added adjectival and demonym to structure #86

wants to merge 1 commit into from

Conversation

oriceon
Copy link

@oriceon oriceon commented Jan 6, 2023

  • fixed Czechia, should be Czech Republic

  • added adjectivals

  • added demonyms

Based on https://en.wikipedia.org/wiki/List_of_adjectival_and_demonymic_forms_for_countries_and_nations

@oriceon
Added adjectival and demonym to structure
5eb6a92 
- fixed Czechia, should be Czech Republic
- added adjectivals
- added demonyms
@oriceon oriceon mentioned this pull request Jan 6, 2023
Open
@alcohol
Copy link
Member

alcohol commented Jan 23, 2023

fixed Czechia, should be Czech Republic

Yes and no, see #68

Your PR is out-of-date currently. I am also not sure how I feel about merging this, similarly to why #68 resulted in a different data provider / class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oriceon @alcohol